Disable rule of hooks in stories files

[ndelangen]

Closes: storybookjs/storybook#21115

What Changed

I chatted with @valentinpalkovic and we concluded that instead of writing an automigration adding code that in neither case looks "quite right", we considered maybe adding an exception to the config exposed by the plugin, which turns off the problems reported from react-hooks eslint plugin.

Checklist

Check the ones applicable to your change:

• Ran yarn update-all
• Tests are updated
• Documentation is updated

Change Type

Indicate the type of change your pull request is:

• maintenance
• documentation
• patch
• minor
• major

📦 Published PR as canary version: 0.7.0--canary.149.b9dd4e1.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

[valentinpalkovic]

LGTM, I am curious what @yannbf thinks about this!

[kasperpeulen]

Can one plugin turn off a rule from another plugin? And are we sure hooks always keep working? Or only if they use storybook hooks?

[ndelangen]

Can one plugin turn off a rule from another plugin?

@kasperpeulen I think this answers your question:
https://github.com/storybookjs/eslint-plugin-storybook/pull/149/files#diff-ded734a061dba2176af9593a93a97d7e478a8aa10774724c78ade7977e783832R13

This very plugin is already doing that.

And are we sure hooks always keep working?

This does not impact runtime of hooks.
There's no difference in react's hooks vs custom hooks for the eslint plugin, you can't disable 1, and not the other.

[yannbf]

make sure to add this to the other config files, else it's all good!

[github-actions]

🚀 PR was released in v0.7.0 🚀

[ndelangen]

To resolve this issue, please use the official storybook eslint plugin. the latest version should resolve this issue, see: https://github.com/storybookjs/eslint-plugin-storybook/releases/tag/v0.7.0