Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/check v8 2 #584

Merged
merged 15 commits into from
Jul 20, 2024
Merged

chore/check v8 2 #584

merged 15 commits into from
Jul 20, 2024

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jun 25, 2024

Introduced WithStorybook metro helper that fixes the errors from 8.2 web and configures metro correctly for storybook

regex error coming from

jsdoc-type-pratt-parser in getQuoted which uses unicode patterns which don't seem to be supported on rn

image

error from @storybook/react templates which reference a non existent button.css

iOS Bundling failed 19266ms index.js (1560 modules)
Unable to resolve "./button.css" from "../../packages/react-native-ui/node_modules/@storybook/react/template/cli/js/Button.jsx"

@dannyhw dannyhw changed the base branch from next to feat/v8 June 25, 2024 23:16
@dannyhw dannyhw marked this pull request as ready for review July 20, 2024 12:52
@dannyhw dannyhw merged commit 1d62ad1 into feat/v8 Jul 20, 2024
1 check passed
@dannyhw dannyhw deleted the chore/check-v8-2 branch July 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant