Merge pull request #102 from subspacecommunity/fix/sonarcloud-issues

Fixing issues picked up by Sonarcloud
subspacecommunity · Jun 26, 2020 · a66eeb4 · a66eeb4
2 parents ab801ec + 4da3bf4
commit a66eeb4
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -6,6 +6,10 @@
 
 [![](https://images.microbadger.com/badges/image/subspacecommunity/subspace.svg)](https://microbadger.com/images/subspacecommunity/subspace "Get your own image badge on microbadger.com") [![](https://images.microbadger.com/badges/version/subspacecommunity/subspace.svg)](https://microbadger.com/images/subspacecommunity/subspace "Get your own version badge on microbadger.com")
 
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=subspacecommunity_subspace&metric=alert_status)](https://sonarcloud.io/dashboard?id=subspacecommunity_subspace)
+[![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=subspacecommunity_subspace&metric=ncloc)](https://sonarcloud.io/dashboard?id=subspacecommunity_subspace)
+[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=subspacecommunity_subspace&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=subspacecommunity_subspace)
+[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=subspacecommunity_subspace&metric=vulnerabilities)](https://sonarcloud.io/dashboard?id=subspacecommunity_subspace)
 - [Subspace - A simple WireGuard VPN server GUI](#subspace---a-simple-wireguard-vpn-server-gui)
   - [Slack](#slack)
   - [Screenshots](#screenshots)

diff --git a/email/footer.html b/email/footer.html
@@ -1,6 +1,4 @@
-                </td>
-            </tr>
-        </table>
+         </div>
     </body>
 </html>
 
diff --git a/email/header.html b/email/header.html
@@ -7,7 +7,7 @@
         <style>
             body, p, td, a, span {
                 color: #737f8d;
-                font-family: "Whitney", "Helvetica Neue", "Helvetica", "Arial", "Lucida Grande", "sans-serif";
+                font-family: Whitney, Helvetica, Arial, sans-serif, "Helvetica Neue", "Lucida Grande";
                 font-size: 18px;
             }
             hr {
@@ -51,7 +51,6 @@
 
                 text-align: center;
                 border-radius: 3px;
-                text-align: center;
             }
             .footer > a {
                 color: #777 !important;
@@ -77,6 +76,4 @@
     </head>
     <body>
 
-        <table class="content" border="0">
-            <tr>
-                <td align="center" valign="top">
+        <div class="content" border="0" align="center" valign="top">
diff --git a/templates/footer.html b/templates/footer.html
@@ -16,7 +16,7 @@
                             <div class="ui hidden clearing divider"></div>
 
                             <div class="ui horizontal divided list">
-                                <a class="item" target="_blank" href="https://github.com/subspacecommunity/subspace">Powered by Subspace</a>
+                                <a class="item" target="_blank" rel="noopener noreferrer" href="https://github.com/subspacecommunity/subspace">Powered by Subspace</a>
                             </div>
                         </div>
 

diff --git a/templates/header.html b/templates/header.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en-GB">
     <head>
         <meta charset="utf-8" />
         <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />

diff --git a/templates/profile/connect.html b/templates/profile/connect.html
@@ -67,7 +67,7 @@
                     <i class="right triangle icon"></i>
                     <div class="content">
                         <div class="description">
-                            Install the <a target="_blank" href="https://itunes.apple.com/us/app/wireguard/id1451685025">WireGuard app</a> from the Mac App Store
+                            Install the <a target="_blank" rel="noopener noreferrer" href="https://itunes.apple.com/us/app/wireguard/id1451685025">WireGuard app</a> from the Mac App Store
                         </div>
                     </div>
                 </div>
@@ -111,7 +111,7 @@
                     <i class="right triangle icon"></i>
                     <div class="content">
                         <div class="description">
-                            Install <a target="_blank" href="https://itunes.apple.com/us/app/wireguard/id1441195209">WireGuard</a> from the App Store
+                            Install <a target="_blank" rel="noopener noreferrer" href="https://itunes.apple.com/us/app/wireguard/id1441195209">WireGuard</a> from the App Store
                         </div>
                     </div>
                 </div>
@@ -142,7 +142,7 @@
             </div>
 
             <div class="ui hidden divider"></div>
-            <img class="ui centered medium image" src="/profile/qrconfig/wireguard/{{$.Profile.ID}}">
+            <img class="ui centered medium image" src="/profile/qrconfig/wireguard/{{$.Profile.ID}}" alt="qr-code could not be displayed">
 
         {{else if eq $.Profile.Platform "android"}}
             <div class="ui large header"><i class="android icon"></i> Android &mdash; Instructions</div>
@@ -151,7 +151,7 @@
                     <i class="right triangle icon"></i>
                     <div class="content">
                         <div class="description">
-                            Install <a target="_blank" href="https://play.google.com/store/apps/details?id=com.wireguard.android">WireGuard for Android</a>
+                            Install <a target="_blank" rel="noopener noreferrer" href="https://play.google.com/store/apps/details?id=com.wireguard.android">WireGuard for Android</a>
                         </div>
                     </div>
                 </div>
@@ -174,7 +174,7 @@
             </div>
 
             <div class="ui hidden divider"></div>
-            <img class="ui centered medium image" src="/profile/qrconfig/wireguard/{{$.Profile.ID}}">
+            <img class="ui centered medium image" src="/profile/qrconfig/wireguard/{{$.Profile.ID}}" alt="qr-code could not be displayed">
 
         {{else if eq $.Profile.Platform "linux"}}
             <div class="ui large header"><i class="linux icon"></i> Linux &mdash; Instructions</div>
@@ -183,7 +183,7 @@
                     <i class="right triangle icon"></i>
                     <div class="content">
                         <div class="description">
-                            Install <a target="_blank" href="https://www.wireguard.com/install/">WireGuard</a>
+                            Install <a target="_blank" rel="noopener noreferrer" href="https://www.wireguard.com/install/">WireGuard</a>
                         </div>
                     </div>
                 </div>
@@ -211,7 +211,7 @@
                     <i class="right triangle icon"></i>
                     <div class="content">
                         <div class="description">
-                            Install <a target="_blank" href="https://www.wireguard.com/install/">WireGuard</a>
+                            Install <a target="_blank" rel="noopener noreferrer" href="https://www.wireguard.com/install/">WireGuard</a>
                         </div>
                     </div>
                 </div>

diff --git a/templates/settings.html b/templates/settings.html
@@ -41,10 +41,10 @@
                 <i class="info circle grey icon"></i>
                 To enable Single Sign-On using SAML add a custom SAML app in your identity provider's admin panel, then copy/paste the IDP metadata XML below.
                 <div class="large ui list">
-                    <a class="item" target="_blank" href="https://support.google.com/a/answer/6087519?hl=en"><i class="right triangle icon"></i>Instructions for G Suite users</a>
-                    <a class="item" target="_blank" href="https://developer.okta.com/standards/SAML/setting_up_a_saml_application_in_okta/"><i class="right triangle icon"></i>Instructions for Okta users</a>
-                    <a class="item" target="_blank" href="https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/configure-single-sign-on-non-gallery-applications"><i class="right triangle icon"></i>Instructions for Azure AD users</a>
-                    <a class="item" target="_blank" href="https://support.jumpcloud.com/support/s/article/getting-started-applications-saml-sso2"><i class="right triangle icon"></i>Instructions for JumpCloud users</a>
+                    <a class="item" target="_blank" rel="noopener noreferrer" href="https://support.google.com/a/answer/6087519?hl=en"><i class="right triangle icon"></i>Instructions for G Suite users</a>
+                    <a class="item" target="_blank" rel="noopener noreferrer" href="https://developer.okta.com/standards/SAML/setting_up_a_saml_application_in_okta/"><i class="right triangle icon"></i>Instructions for Okta users</a>
+                    <a class="item" target="_blank" rel="noopener noreferrer" href="https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/configure-single-sign-on-non-gallery-applications"><i class="right triangle icon"></i>Instructions for Azure AD users</a>
+                    <a class="item" target="_blank" rel="noopener noreferrer" href="https://support.jumpcloud.com/support/s/article/getting-started-applications-saml-sso2"><i class="right triangle icon"></i>Instructions for JumpCloud users</a>
                 </div>
             </div>
             <div class="ui hidden divider"></div>