[rector] add more default sets, bump php cs fixer, phpunit

[TomasVotruba]

No description provided.

[TomasVotruba]

I've bumped the PHPUnit to 10, which is the highest version with BC changes so far, so no need for extra upgrade sets.

[alexander-schranz]

What is strange is that a basic symfony still installs PHPUnit 9:

composer create-project symfony/skeleton
cd skeleton
composer require test

Need todo some research why it is so 🤔

[TomasVotruba]

I don't think flex + related hacks are maintained much. Composer require works well:

composer create-project symfony/skeleton
cd skeleton
composer require phpunit/phpunit

[TomasVotruba]

Good to go 👍

[TomasVotruba]

If I may suggest, phpunit-bridge is suitable for developing symfony/symfony core monorepo, as they need to test various conflicting PHP versions. Not for own tools/projects.
We use PHP 8.1+ here, so we're good with bare PHPUnit 👍 It also works better with PHPStan and Rector.

[TomasVotruba]

Just an experiment to see if CI passes 👍

[TomasVotruba]

This class does not exist anymore, that's why CI was failing.
There is no added value of this custom bin file over vendor/bin/phpunit

[alexander-schranz]

will check this with the symfony recipe. because if we don't provide it the flex recipe will automatically create it.

[alexander-schranz]

I tried the config in a existing project and stumbled over an unexpected behaviour trying out the config.

The project using PHPUnit 9. Rector wants to update the attributes, think would nice to avoid that if PHPUnit 9 is used as I think attributes only supported by PHPUnit 10?:

rector.php

<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Doctrine\Set\DoctrineSetList;
use Rector\PHPUnit\PHPUnit100\Rector\Class_\StaticDataProviderClassMethodRector;
use Rector\PHPUnit\Set\PHPUnitLevelSetList;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Symfony\CodeQuality\Rector\MethodCall\LiteralGetToRequestClassConstantRector;
use Rector\Symfony\Set\SymfonyLevelSetList;
use Rector\Symfony\Set\SymfonySetList;
use Sulu\Rector\Set\SuluLevelSetList;

return RectorConfig::configure()
    ->withPaths([
        __DIR__ . '/src',
        __DIR__ . '/tests',
    ])
    ->withRootFiles()
    ->withPhpSets()
    ->withPreparedSets(
        codeQuality: true,
        doctrineCodeQuality: true,
        symfonyCodeQuality: true,
        deadCode: true,
        codingStyle: true,
        instanceOf: true,
        typeDeclarations: true,
    )
    ->withImportNames(importShortClasses: false)
    ->withAttributesSets(all: true)
    ->withSymfonyContainerPhp(__DIR__ . '/var/cache/website/dev/App_KernelDevDebugContainer.xml')
    ->withSets([
        // - activate when doing symfony updates:
        // SymfonyLevelSetList::UP_TO_SYMFONY_64,
        // - activate when doing phpunit updates:
        // PHPUnitSetList::PHPUNIT_91,
        // PHPUnitSetList::PHPUNIT_100,
        // - activate when doing sulu updates:
        // SuluLevelSetList::UP_TO_SULU_25,
    ])
    ->withPHPStanConfigs([
        __DIR__ . '/phpstan.dist.neon',
        // rector does not load phpstan extension automatically so require them manually here:
        __DIR__ . '/vendor/phpstan/phpstan-doctrine/extension.neon',
        __DIR__ . '/vendor/phpstan/phpstan-symfony/extension.neon',
    ]);

[TomasVotruba]

The project using PHPUnit 9. Rector wants to update the attributes

I'll look into Rector attribute sets.

There composer.json here requires "phpunit/phpunit": "^10.5", so we're safe.

[alexander-schranz]

I know but is there a way to use this config and still use PHPUnit 9 avoid the attributes upgrade only for PHPUnit? In some other cases were we use Rector we want to use same configs. Maybe we can fix it directly in Rector with check for if (!Composer::satisfies('phpunit/phpunit', '<10.0')) { not todo the upgrade, sure the one using phar wouldn't be catched but atleast the once who have phpunit in the composer.json and use still the older versions will no be updated automatically.

[alexander-schranz]

The CI error looks unrelated to your changes. I will have a look at it.

PS: Like the codeQuality rules nice little catches in them 👍

[TomasVotruba]

I know but is there a way to use this config and still use PHPUnit 9 avoid the attributes upgrade only for PHPUnit? In some other cases were we use Rector we want to use same configs.

Not yet, but I'll add it to Rector. Valid point 👍

[TomasVotruba]

My work is done here, need to continue upgrading :)
Feel free to cherry pick what you like and drop the rest 👍

[alexander-schranz]

@TomasVotruba thank you :)