Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 to test matrix #263

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Nov 27, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT
Documentation PR sulu/sulu-docs#prnum

What's in this PR?

Add PHP 8.4 to test matrix.

Why?

We prepare the next release make sure to test also against PHP 8.4 the latest PHP version released last week.

@@ -54,7 +54,7 @@ jobs:
SULU_ADMIN_EMAIL:
DATABASE_URL: "mysql://root:@127.0.0.1:3306/sulu_test?serverVersion=8.0"

- php-version: '8.3'
- php-version: '8.4'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scheb 2FA packages are not compatible with PHP 8.4 only the 7.0 so we can test against PHP 8.4 only on 2.6 branch.

@alexander-schranz alexander-schranz force-pushed the enhancement/php-8-4 branch 2 times, most recently from f5158c7 to 37c2392 Compare November 27, 2024 10:55
@alexander-schranz
Copy link
Member Author

Not sure why composer seems behave differently on windows and clone 2.5.21 instead of 2.5.*@dev. Currently ignoring this error.

@alexander-schranz alexander-schranz merged commit e7afcd5 into sulu:2.5 Nov 27, 2024
3 of 4 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/php-8-4 branch November 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant