Update Redis url and add hybrid search support #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svonava
reviewed
Nov 18, 2024
docs/tools/vdb_table/data/redis.json
Outdated
| @@ -32,9 +32,9 @@ | |||
| "comment": "" | |||
| }, | |||
| "hybrid_search": { | |||
| "support": "", | |||
| "support": "full", | |||
| "source_url": "", | |||
There was a problem hiding this comment.
@tylerhutcherson can you add link to docs for the feature?
There was a problem hiding this comment.
At the moment we just have these notebook examples linked in the comment, but we are working on adding it to our documentation as well. Will ping when we have the link ready
There was a problem hiding this comment.
ok then let's add the link to the notebook into the source_url for now, which will make it easy to discover and click from the comparison table
There was a problem hiding this comment.
will do -- we should have an updated docs page ASAP and I can come back and make that update too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks to the Redis information:
.iosite where appropriate.