Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add italian localization #71

Closed
wants to merge 1 commit into from

Conversation

zanhk
Copy link

@zanhk zanhk commented Nov 21, 2023

@kyoshino I will work on this tomorrow, if in the future you need to add more localization keys just put the english one and ping me.

@zanhk zanhk changed the title Add italian localization WIP: Add italian localization Nov 21, 2023
@zanhk zanhk marked this pull request as draft November 21, 2023 22:50
@zanhk
Copy link
Author

zanhk commented Nov 21, 2023

@kyoshino Can you connect the issue #70? thanks

@kyoshino
Copy link
Member

kyoshino commented Nov 22, 2023

I really appreciate this, but it’s too early to start l10n. (The Japanese l10n exists because I’ve developed this CMS for my clients, who are mostly in Japan.)

Since many features are still missing, many strings will be added before 1.0, including many invisible labels for accessibility. I’ll keep #70 open and ping you early next year when the strings are better organized, polished, and more stable.

Actually, the string format may also change. The current library is svelte-i18n, but I’ll evaluate other options since it doesn’t even support singular/plural switches. Some locales are complicated — Fluent (created for Mozilla Firefox, svelte-fluent) might be a better choice.

Let me know if you have an opinion on Italian 🙂 (Japanese is too simple, there is mostly no plural form, gender, or whatever)

Edit: I’ve realized that the Fluent homepage has an Italian example, which shows a lowercase variant.

Edit: I think I’ll create my own Svelte wrapper for Fluent.js.

@kyoshino kyoshino closed this Nov 22, 2023
@kyoshino
Copy link
Member

Tip: When you write “Fix #70”, “Close #70”, etc. in the pull request description, the PR and issue will be automatically linked, and the issue will be automatically closed when the PR is merged. 😺 See:

@zanhk
Copy link
Author

zanhk commented Nov 22, 2023

I really appreciate this, but it’s too early to start l10n. (The Japanese l10n exists because I’ve developed this CMS for my clients, who are mostly in Japan.)

Since many features are still missing, many strings will be added before 1.0, including many invisible labels for accessibility. I’ll keep #70 open and ping you early next year when the strings are better organized, polished, and more stable.

Actually, the string format may also change. The current library is svelte-i18n, but I’ll evaluate other options since it doesn’t even support singular/plural switches. Some locales are complicated — Fluent (created for Mozilla Firefox, svelte-fluent) might be a better choice.

Let me know if you have an opinion on Italian 🙂 (Japanese is too simple, there is mostly no plural form, gender, or whatever)

Edit: I’ve realized that the Fluent homepage has an Italian example, which shows a lowercase variant.

Edit: I think I’ll create my own Svelte wrapper for Fluent.js.

Ok

@kyoshino
Copy link
Member

I’ve added README for localizers 😅 You’re good as you’ve filed an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants