Support Flann and Cereal from external dependencies #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KindDragon
force-pushed
the
external_flann
branch
from
99f89cf to
09be14d
Compare
KindDragon
changed the title
KindDragon
force-pushed
the
external_flann
branch
7 times, most recently
from
aade246 to
a354f02
Compare
|
Ready to merge. Closes #166 |
KindDragon
force-pushed
the
external_flann
branch
from
a9d630d to
73a0482
Compare
KindDragon
force-pushed
the
external_flann
branch
from
73a0482 to
1e3f86a
Compare
|
I can move second commit to separate PR if you want |
|
I'll try to review and pull these changes in soon. Sorry for the delay! Things have been very busy lately. |
|
Could you move the second commit to a different PR? I'm still debating if the first one should be pulled into the main repo... it adds a lot of ugliness to the CMake (which is already pretty ugly) and I'm not enough of a CMake expert to understand all the consequences this may have when installing Theia as a library |
KindDragon
force-pushed
the
external_flann
branch
from
1e3f86a to
5e0f8a7
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.