Remove empty post-init-counsel-gtags functions (#16735)

* [windows-scripts] Remove useless :if property

This property isn't read by anything.  :toggle is the correct way to
conditionally enable a package, and in any case, windows-scripts isn't
the owning layer for this package so it cannot disable it.

* Remove empty post-init-counsel-gtags functions

Follow up to #16476.

layers/+lang/asm/packages.el

@@ -28,7 +28,6 @@
         company
         electric-indent-mode
         ggtags
-        counsel-gtags
         nasm-mode
         x86-lookup
         ))
@@ -74,5 +73,3 @@
 
 (defun asm/post-init-ggtags ()
   (add-hook 'asm-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun asm/post-init-counsel-gtags nil)

layers/+lang/c-c++/packages.el

@@ -45,7 +45,6 @@
     dap-mode
     ;; rtags
     (company-rtags :requires (company rtags))
-    counsel-gtags
     (flycheck-rtags :requires (flycheck rtags))
     ggtags
     (helm-rtags :requires (helm rtags))
@@ -126,8 +125,6 @@
     :defer t
     :commands company-ycmd))
 
-(defun c-c++/post-init-counsel-gtags nil)
-
 (defun c-c++/init-cpp-auto-include ()
   (use-package cpp-auto-include
     :defer t

layers/+lang/clojure/packages.el

@@ -44,7 +44,6 @@
                                            (list clojure-enable-linters))))
     ggtags
     (kaocha-runner :toggle clojure-enable-kaocha-runner)
-    counsel-gtags
     org
     popwin
     (sayid :toggle clojure-enable-sayid)
@@ -476,8 +475,6 @@
 (defun clojure/post-init-ggtags ()
   (add-hook 'clojure-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 
-(defun clojure/post-init-counsel-gtags nil)
-
 (defun clojure/init-clojure-snippets ()
   (use-package clojure-snippets
     :defer t))

layers/+lang/common-lisp/packages.el

@@ -29,7 +29,6 @@
     evil-cleverparens
     evil-collection
     ggtags
-    counsel-gtags
     helm
     org
     rainbow-identifiers
@@ -71,8 +70,6 @@
 (defun common-lisp/post-init-ggtags ()
   (add-hook 'common-lisp-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 
-(defun common-lisp/post-init-counsel-gtags nil)
-
 (defun common-lisp/pre-init-org ()
   (spacemacs|use-package-add-hook org
     :post-config (add-to-list 'org-babel-load-languages '(lisp . t))))

layers/+lang/csharp/packages.el

@@ -27,7 +27,6 @@
         (csharp-mode :toggle (version< emacs-version "29.0.60"))
         evil-matchit
         ggtags
-        counsel-gtags
         omnisharp
         flycheck
         ))
@@ -60,5 +59,3 @@
 
 (defun csharp/post-init-ggtags ()
   (add-hook 'csharp-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun csharp/post-init-counsel-gtags nil)

layers/+lang/d/packages.el

@@ -30,8 +30,7 @@
         d-mode
         flycheck
         (flycheck-dmd-dub :requires flycheck)
-        ggtags
-        counsel-gtags))
+        ggtags))
 
 
 (defun d/post-init-company ()
@@ -63,5 +62,3 @@
 
 (defun d/post-init-ggtags ()
   (add-hook 'd-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun d/post-init-counsel-gtags nil)

layers/+lang/elixir/packages.el

@@ -25,7 +25,6 @@
   '(
     alchemist
     company
-    counsel-gtags
     dap-mode
     elixir-mode
     evil-matchit
@@ -157,8 +156,6 @@
   ;; backend specific
   (add-hook 'elixir-mode-local-vars-hook #'spacemacs//elixir-setup-company))
 
-(defun elixir/post-init-counsel-gtags nil)
-
 (defun elixir/pre-init-dap-mode ()
   (when (eq elixir-backend 'lsp) (add-to-list 'spacemacs--dap-supported-modes 'elixir-mode))
   (add-hook 'elixir-mode-local-vars-hook #'spacemacs//elixir-setup-dap))

layers/+lang/emacs-lisp/packages.el

@@ -39,7 +39,6 @@
     flycheck-elsa
     flycheck-package
     ggtags
-    counsel-gtags
     (ielm :location built-in)
     (inspector :location (recipe
                           :fetcher github
@@ -319,8 +318,6 @@
   (use-package flycheck-elsa
     :hook (emacs-lisp-mode . flycheck-elsa-setup)))
 
-(defun emacs-lisp/post-init-counsel-gtags nil)
-
 (defun emacs-lisp/post-init-ggtags ()
   (add-hook 'emacs-lisp-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 

layers/+lang/erlang/packages.el

@@ -27,7 +27,6 @@
         erlang
         dap-mode
         ggtags
-        counsel-gtags
         flycheck))
 
 
@@ -64,5 +63,3 @@
 
 (defun erlang/post-init-ggtags ()
   (add-hook 'erlang-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun erlang/post-init-counsel-gtags nil)

layers/+lang/fsharp/packages.el

@@ -24,7 +24,6 @@
 (defconst fsharp-packages
   '(
     company
-    counsel-gtags
     (eglot-fsharp :toggle (eq fsharp-backend 'eglot))
     flycheck
     fsharp-mode
@@ -73,5 +72,3 @@
 
 (defun fsharp/post-init-ggtags ()
   (add-hook 'fsharp-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun fsharp/post-init-counsel-gtags nil)

layers/+lang/go/packages.el

@@ -27,7 +27,6 @@
     dap-mode
     (company-go :requires company
                 :toggle (eq go-backend 'go-mode))
-    counsel-gtags
     eldoc
     flycheck
     (flycheck-golangci-lint :toggle (and go-use-golangci-lint
@@ -60,8 +59,6 @@
     (add-to-list 'spacemacs--dap-supported-modes 'go-mode))
   (add-hook 'go-mode-local-vars-hook #'spacemacs//go-setup-dap))
 
-(defun go/post-init-counsel-gtags nil)
-
 (defun go/post-init-eldoc ()
   (add-hook 'go-mode-local-vars-hook #'spacemacs//go-setup-eldoc))
 

layers/+lang/haskell/packages.el

@@ -39,7 +39,6 @@
         ggtags
         haskell-mode
         haskell-snippets
-        counsel-gtags
         (helm-hoogle :requires helm)
         hindent
         hlint-refactor))
@@ -309,8 +308,6 @@
 
   (with-eval-after-load 'yasnippet (haskell-snippets-initialize)))
 
-(defun haskell/post-init-counsel-gtags nil)
-
 ;; doesn't support haskell-literate-mode :(
 (defun haskell/init-hindent ()
   (use-package hindent

layers/+lang/java/packages.el

@@ -27,7 +27,6 @@
     dap-mode
     flycheck
     ggtags
-    counsel-gtags
     (java-mode :location built-in)
     maven-test-mode
     (meghanada :toggle (eq java-backend 'meghanada))
@@ -54,8 +53,6 @@
   (with-eval-after-load 'smartparens
     (sp-local-pair 'java-mode "/** " " */" :trigger "/**")))
 
-(defun java/post-init-counsel-gtags nil)
-
 (defun java/pre-init-org ()
   (spacemacs|use-package-add-hook org
     :post-config (add-to-list 'org-babel-load-languages '(java . t))))

layers/+lang/javascript/packages.el

@@ -25,7 +25,6 @@
   '(
     add-node-modules-path
     company
-    counsel-gtags
     dap-mode
     evil-matchit
     flycheck
@@ -52,8 +51,6 @@
 (defun javascript/post-init-company ()
   (add-hook 'js2-mode-local-vars-hook #'spacemacs//javascript-setup-company))
 
-(defun javascript/post-init-counsel-gtags nil)
-
 (defun javascript/pre-init-dap-mode ()
   (when (eq javascript-backend 'lsp)
     (add-to-list 'spacemacs--dap-supported-modes 'js2-mode))

layers/+lang/kotlin/packages.el

@@ -27,7 +27,6 @@
     flycheck
     (flycheck-kotlin :requires flycheck)
     ggtags
-    counsel-gtags
     kotlin-mode))
 
 (defun kotlin/post-init-company ()
@@ -50,5 +49,3 @@
 
 (defun kotlin/post-init-ggtags ()
   (add-hook 'kotlin-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun kotlin/post-init-counsel-gtags nil)

layers/+lang/latex/packages.el

@@ -31,7 +31,6 @@
     (company-math :requires company math-symbol-lists)
     (company-auctex :requires company)
     (company-reftex :requires company)
-    counsel-gtags
     evil-matchit
     evil-tex
     flycheck
@@ -233,8 +232,6 @@
       (concat prefix "T")    'reftex-toc-recenter
       (concat prefix "v")    'reftex-view-crossref)))
 
-(defun latex/post-init-counsel-gtags nil)
-
 (defun latex/post-init-ggtags ()
   (add-hook 'latex-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 

layers/+lang/lua/packages.el

@@ -27,7 +27,6 @@
     (company-lua :requires company)
     flycheck
     ggtags
-    counsel-gtags
     lua-mode))
 
 (defun lua/post-init-flycheck ()
@@ -71,5 +70,3 @@
 
 (defun lua/post-init-ggtags ()
   (add-hook 'lua-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun lua/post-init-counsel-gtags nil)

layers/+lang/ocaml/packages.el

@@ -29,7 +29,6 @@
     flycheck
     (flycheck-ocaml :toggle (configuration-layer/layer-used-p 'syntax-checking))
     ggtags
-    counsel-gtags
     imenu
     merlin
     merlin-company
@@ -95,8 +94,6 @@
 (defun ocaml/post-init-ggtags ()
   (add-hook 'ocaml-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 
-(defun ocaml/post-init-counsel-gtags nil)
-
 (defun ocaml/init-merlin ()
   (use-package merlin
     :defer t

layers/+lang/octave/packages.el

@@ -24,7 +24,6 @@
 (setq octave-packages
       '(
         ggtags
-        counsel-gtags
         (octave :location built-in)
         ))
 
@@ -47,5 +46,3 @@
 
 (defun octave/post-init-ggtags ()
   (add-hook 'octave-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
-
-(defun octave/post-init-counsel-gtags nil)

layers/+lang/php/packages.el

@@ -29,7 +29,6 @@
     evil-matchit
     flycheck
     ggtags
-    counsel-gtags
     (php-auto-yasnippets :location (recipe :fetcher github :repo "emacs-php/php-auto-yasnippets"))
     (php-extras :location (recipe :fetcher github :repo "arnested/php-extras") :toggle (not (eq php-backend 'lsp)))
     php-mode
@@ -57,8 +56,6 @@
 (defun php/post-init-ggtags ()
   (add-hook 'php-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 
-(defun php/post-init-counsel-gtags nil)
-
 (defun php/post-init-evil-matchit ()
   (add-hook 'php-mode-hook 'turn-on-evil-matchit-mode))
 

layers/+lang/python/packages.el

@@ -26,7 +26,6 @@
     blacken
     code-cells
     company
-    counsel-gtags
     cython-mode
     dap-mode
     eldoc
@@ -160,8 +159,6 @@
     :post-init
     (spacemacs/setup-helm-cscope 'python-mode)))
 
-(defun python/post-init-counsel-gtags nil)
-
 (defun python/post-init-ggtags ()
   (add-hook 'python-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 

layers/+lang/racket/packages.el

@@ -26,7 +26,6 @@
         company
         company-quickhelp
         ggtags
-        counsel-gtags
         evil-cleverparens
         racket-mode
         ))
@@ -49,8 +48,6 @@
 (defun racket/post-init-ggtags ()
   (add-hook 'racket-mode-local-vars-hook #'spacemacs/ggtags-mode-enable))
 
-(defun racket/post-init-counsel-gtags nil)
-
 (defun racket/pre-init-evil-cleverparens ()
   (spacemacs|use-package-add-hook evil-cleverparens
     :pre-init
@@ -159,4 +156,3 @@
       "tb" 'racket-test
       "tB" 'spacemacs/racket-test-with-coverage)
     (define-key racket-mode-map (kbd "H-r") 'racket-run)))
-

layers/+lang/ruby/packages.el

@@ -27,7 +27,6 @@
     bundler
     chruby
     company
-    counsel-gtags
     dap-mode
     (enh-ruby-mode :toggle ruby-enable-enh-ruby-mode)
     evil-matchit
@@ -80,8 +79,6 @@
 (defun ruby/post-init-company ()
   (add-hook 'ruby-mode-local-vars-hook #'spacemacs//ruby-setup-company))
 
-(defun ruby/post-init-counsel-gtags nil)
-
 (defun ruby/pre-init-dap-mode ()
   (when (eq ruby-backend 'lsp)
     (add-to-list 'spacemacs--dap-supported-modes 'ruby-mode)

layers/+lang/rust/packages.el

@@ -23,16 +23,13 @@
 
 (defconst rust-packages
   '(
-    counsel-gtags
     dap-mode
     ggtags
     ron-mode
     rustic
     smartparens))
 
 
-(defun rust/post-init-counsel-gtags nil)
-
 (defun rust/pre-init-dap-mode ()
   (when (eq rust-backend 'lsp)
     (add-to-list 'spacemacs--dap-supported-modes 'rustic-mode)