Skip to content

Commit

Permalink
feature #1242 [DX] Update .gitattributes & .gitignores files (smnandre)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[DX] Update .gitattributes & .gitignores files

StimulusBundle did not have a `.gitattributes` file, packaging all the tests code (see: [symfony/stimulus-bundle](https://cdn.jsdelivr.net/gh/symfony/stimulus-bundle/)  VS. [symfony/ux-twig-component](https://cdn.jsdelivr.net/gh/symfony/ux-twig-component/)

| NOK | OK |
| - | - |
| ![stimulus-bundle](https://github.com/symfony/ux/assets/1359581/c82d78dd-535c-4f17-a96a-70895f167c43) | ![twig-component](https://github.com/symfony/ux/assets/1359581/76bacad4-7c39-4fce-a389-bfe3c2a07fe8) |

I used the occasion to check / refresh all the packages `.gitignore` and `.gitattributes` and
* add missing phpunit.xml.dist (once)
* remove unnecessary .gitignore files
* simplify export rules about assets/src files

Commits
-------

35832ab [DX] Update .gitattributes & .gitignores files
  • Loading branch information
weaverryan committed Nov 6, 2023
2 parents 19dd9be + 35832ab commit 3b011be
Show file tree
Hide file tree
Showing 18 changed files with 32 additions and 30 deletions.
5 changes: 2 additions & 3 deletions src/Autocomplete/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/.gitignore export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
1 change: 0 additions & 1 deletion src/Autocomplete/assets/.gitignore

This file was deleted.

4 changes: 2 additions & 2 deletions src/Chartjs/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/assets/vitest.config.js export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
4 changes: 2 additions & 2 deletions src/Cropperjs/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
4 changes: 2 additions & 2 deletions src/Dropzone/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
4 changes: 2 additions & 2 deletions src/LazyImage/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
4 changes: 1 addition & 3 deletions src/LiveComponent/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/.gitignore export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
1 change: 0 additions & 1 deletion src/LiveComponent/assets/.gitignore

This file was deleted.

4 changes: 2 additions & 2 deletions src/Notify/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
4 changes: 2 additions & 2 deletions src/React/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/assets/vitest.config.js export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
7 changes: 7 additions & 0 deletions src/StimulusBundle/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/assets/src export-ignore
/assets/test export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
6 changes: 3 additions & 3 deletions src/Svelte/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/assets/.gitignore export-ignore
/assets/vitest.config.js export-ignore
/assets/src export-ignore
/assets/test export-ignore
/assets/vitest.config.js export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore
/assets/src/*.ts export-ignore
3 changes: 2 additions & 1 deletion src/Svelte/.gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/assets/node_modules
/composer.lock
/phpunit.xml
/vendor/
/.phpunit.result.cache
/.phpunit.result.cache
1 change: 0 additions & 1 deletion src/Svelte/assets/.gitignore

This file was deleted.

2 changes: 1 addition & 1 deletion src/Swup/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
2 changes: 1 addition & 1 deletion src/Turbo/.gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/phpstan.neon.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/assets/vitest.config.js export-ignore
/tests export-ignore
2 changes: 1 addition & 1 deletion src/Typed/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
4 changes: 2 additions & 2 deletions src/Vue/.gitattributes
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.symfony.bundle.yaml export-ignore
/phpunit.xml.dist export-ignore
/assets/src/**/*.ts export-ignore
/assets/src export-ignore
/assets/test export-ignore
/assets/vitest.config.js export-ignore
/phpunit.xml.dist export-ignore
/tests export-ignore

0 comments on commit 3b011be

Please sign in to comment.