Migrate from Jest to Vitest #1202
Conversation
|
Thanks for this 💯! I'm going to try to find time to dig a bit this weekend. |
|
Does it support parralel runs ? something like (not working, just to illustrate) |
|
@smnandre Not in the current state as this project uses yarn 1.22 (classic) but with yarn v3+ you can: yarn workspaces foreach --parallel run test |
|
@ChqThomas ok thanks So it's probably out of the scope of your current work.. I'd like to work the CI to speed things a bit (a lot?), because i must admin having to wait 2 minutes of JS scripts every time i touch a PHP file is not something i love :) 
And, as far as i know, it would not be a good idea to condition JS runs to .js files change (as php and js files can impact each other in our packages) I'm looking at esbuild right now, it could help us Should i create an issue to discuss this ? WDYT ? (cc @weaverryan ) |
Sure - I'd be interested to see what you have in mind 👍 |
Fixes: Error: Uncaught [ReferenceError: Node is not defined]
|
Ok, checked into this. Fantastic work - it got me really excited and I think this is going to work! Using your detailed notes, I added a few more commits and resolved many of the remaining issues. So, we're actually quite close now. I also added a little script that will run all the workspace tests and continue going even if some fail. Just running A few svelte tests are failing... the markup apparently changed that Svelte is outputting? I'm not sure what's going on there - but there's a good chance we can just change the assertions to match the new markup, though I can't explain the change. EDIT: I've fixed the rest. I think this might be working! @ChqThomas do you want to remove jest and see if anything else needs to be done? I'm not worried about benchmarking, btw - the tests are fast. If we need to do something faster or run them in parallel, that's a separate thing. |
| @@ -5,6 +5,7 @@ | |||
| "module": "dist/register_controller.js", | |||
| "version": "1.0.0", | |||
| "license": "MIT", | |||
| "type": "module", | |||
There was a problem hiding this comment.
@stof I'm wondering if I could get your advice. This was needed to get @sveltejs/vite-plugin-svelte to play nicely. In reality, we are already using import inside all packages and our users are using import. So, do you have any concern about this change? If not, we should apply it equally across all packages.
|
@weaverryan Wow that was fast!
I can't explain it either, Svelte add HTML comments to identify components in dev mode, seems like they are not stripped out of the output with the Vitest plugin like they were with the Jest one. Updating the assertions is fine 👍
Yup I'll take a final look and completely remove jest config Great work 😄 |
|
Thank you very very much Thomas! |
|
I'm not sure (never heard of vitest until last week so i'm no expert.. at all)... but it seems that we are not using the vitests workspaces ? Is it not worth it ? Or not a need for this repo ? |
|
I wasn't aware of them - so maybe something can be improved |
This PR was merged into the 2.x branch. Discussion ---------- [ChartJs] Add support for chart.js:^4.0 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Issues | Fix #607 | License | MIT Since #1202 has been merged, which solved the blockage of #610, the support for ChartJs v4 should be as simple as this PR :) and would replace #610. 🤞🏼 on the CI-flow Commits ------- 56d925a [ChartJs] Add support for chart.js:^4.0
This PR is a draft to test the feasibility of migrating from jest to vitest
Jest doesn't support ESM out of the box, which makes it difficult to test some libraries like Chart.js and Svelte v4. Vitest supports typescript and ESM by default and is compatible with Jest API, it'll help us test those packages and maybe others in the future
Infos:
There is a global config file
vitest.config.jswhich contains the default settings for every package, when needed it can be extended with a file in the package root (ex:src\React\assets\vitest.config.js)I replaced the
yarn testscript withvitest src --runso it's run globally and the CI doesn't stop at the first error from a package, it still can be run for every/individual packages withyarn workspaces run vitest --run/yarn workspace "@symfony/ux-live-component" run vitest --runLibraries like fetch-mock-jest and jest-canvas-mock need to be replaced
The
require_context_poylfill.tsfile used by ux-react, ux-vue and ux-svelte needs to be modified as it uses a dynamicrequire, replacing it with animportdoesn't work as it is asynchronousResources:
TODO:
0/140/41/13/31/1217/217💯Error: Uncaught [ReferenceError: Node is not defined]Just a warning but the test suite pass1/10/4require_context_poylfill.ts1/1Error: Uncaught [ReferenceError: Node is not defined]Just a warning but the test suite pass0/4require_context_poylfill.ts0/5require() of ES Module node_modules/delegate-it/index.js from node_modules/swup/lib/index.js not supported.1/191/910/2TypeError: Cannot read properties of undefined (reading 'prototype')1/10/5require_context_poylfill.tsI'll need help to resolve these issues 😁