Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "type: module" for all packages and changing main -> module #1224

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

weaverryan
Copy link
Member

Q A
Bug fix? no
New feature? yes
Tickets None
License MIT

Follow up on https://github.com/symfony/ux/pull/1202/files#r1367791334

We already use ESM inside of our packages. This makes that official with type: module. Some notes / questions:

A) I believe, since we already ONLY made "modules" available, that this will have no effect on end users, but I'm not 100% sure about that. If someone is using require instead of import, it would affect them... but in that case, I believe require would not have worked before anyway. But if anyone knows better than I do, I'd appreciate your notes.

B) Because we are a type: module, my impression is that main will not be used. And we can instead rely on module.

tl;dr I believe these changes won't have user-facing effects, but I'm not 100% sure about that... though I'm pretty sure that if they DO have user-facing effects, it would be limited to people who are currently using require with these packages.

Cheers!

@weaverryan weaverryan merged commit 1db34a8 into symfony:2.x Nov 7, 2023
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant