Add "type: module" for all packages and changing main -> module #1224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on https://github.com/symfony/ux/pull/1202/files#r1367791334
We already use ESM inside of our packages. This makes that official with
type: module
. Some notes / questions:A) I believe, since we already ONLY made "modules" available, that this will have no effect on end users, but I'm not 100% sure about that. If someone is using
require
instead ofimport
, it would affect them... but in that case, I believerequire
would not have worked before anyway. But if anyone knows better than I do, I'd appreciate your notes.B) Because we are a
type: module
, my impression is thatmain
will not be used. And we can instead rely onmodule
.tl;dr I believe these changes won't have user-facing effects, but I'm not 100% sure about that... though I'm pretty sure that if they DO have user-facing effects, it would be limited to people who are currently using
require
with these packages.Cheers!