Remove "type": "module" from all package.json files #1268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
We recommend converting your config to ESM by either:
adding "type": "module" to the nearest package.json
renaming vite.config.js/vite.config.ts to vite.config.mjs/vite.config.mts
```
So i used the second one and it seems to work
https://vitejs.dev/guide/troubleshooting.html#config
|
Thank you Simon! |
|
PR was merged... just didn't close |
weaverryan
added a commit
that referenced
this pull request
Nov 11, 2023
This PR was squashed before being merged into the 2.x branch. Discussion ---------- Remove "type": "module" from all package.json files Since #1264, another person could not build its assets with Encore and a babel plugin. So for now we decided to revert the "type: module" declaration. ### Revert the "type: module" Remove this "type" line from all package.json files and revert replacing "main:" with "module:" Before ```json "type": "module", "module": "dist/foo.js", ``` After ```json "main": "dist/foo.js", ``` ### Fix Svelte ESM bug with vite/vitest ``` We recommend converting your config to ESM by either: adding "type": "module" to the nearest package.json renaming vite.config.js/vite.config.ts to vite.config.mjs/vite.config.mts ``` (https://vitejs.dev/guide/troubleshooting.html#config) So i used the second one.... and it seems to work Commits ------- 919ade7 Remove "type": "module" from all package.json files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1264, another person could not build its assets with Encore and a babel plugin.
So for now we decided to revert the "type: module" declaration.
Revert the "type: module"
Remove this "type" line from all package.json files and revert replacing "main:" with "module:"
Before
After
Fix Svelte ESM bug with vite/vitest
(https://vitejs.dev/guide/troubleshooting.html#config)
So i used the second one.... and it seems to work