[RFC][Site] replace highlight.js with tempest/highlight
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Apr 16, 2024
| @@ -13,7 +13,7 @@ | |||
| <pre | |||
| {% if height %} style="--height: {{ height }}" {% endif %} | |||
| data-clipboarder-target="source" | |||
| ><code {% if highlight %} data-code-highlighter-target="codeBlock" {% endif %}>{{ __code ? __code|trim|raw : code }}</code></pre> | |||
| ><code>{{ __code ? __code|trim|raw : code }}</code></pre> | |||
There was a problem hiding this comment.
I broke the highlighting here so this needs to be fixed. Does highlight.js detect the language?
smnandre
reviewed
Apr 17, 2024
| @@ -21,7 +21,7 @@ jobs: | |||
|
|
|||
| - uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: 8.1 | |||
| php-version: 8.3 | |||
It's not that hard i think. Let's add this to my ever-growing-todo-list 😅 |
|
That's a nice improvement, especially for web perfs 👀 For |
WebMamba
reviewed
Apr 17, 2024
I agree, closing. |
smnandre
reviewed
Apr 30, 2024
| use Tempest\Highlight\Highlighter; | ||
|
|
||
| /** | ||
| * TODO: remove this class when/if https://github.com/tempestphp/highlight/pull/102 is merged. |
There was a problem hiding this comment.
Good: tempestphp/highlight#102
kbond
added a commit
that referenced
this pull request
Apr 30, 2024
…(kbond) This PR was merged into the 2.x branch. Discussion ---------- [Site] switch from `highlight.js` to `tempest/highlight` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Continuation of #1742. I now fully removed highlight.js. Commits ------- 22ef22e [Site] switch from `highlight.js` to `tempest/highlight`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(depends on #1740)
I couldn't remove
highlight.jsentirely astranslation-demo-controller.jsstill requires it and I don't think we can easily refactor it out. I don't really want to maintain two syntax highlighters (+styling) so I'm not sure this PR is worth it...