Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbo] Fix Doctrine Proxy are not Broadcasted #1929

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[Turbo] Fix Doctrine Proxy are not Broadcasted #1929

merged 1 commit into from
Jun 26, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Jun 20, 2024 •
edited
Loading

Q A
Bug fix? yes
New feature? no
Issues Fix #...
License MIT
  • Resolve old Doctrine proxy class
  • Make the CI green again?

Update: this fix the bug you can experience on this page: https://ux.symfony.com/turbo

Capture d’écran 2024-06-20 à 17 01 25

@carsonbot carsonbot added Bug Bug Fix Turbo Status: Needs Review Needs to be reviewed labels Jun 20, 2024
@smnandre smnandre requested review from kbond and WebMamba June 20, 2024 06:25
WebMamba
WebMamba reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yooooo!

when I try this PR, and click on the link to try the TurboFrame, I have this error :
Capture d’écran 2024-06-21 à 11 33 07

It looks like the meta data are not correctly passed. Do you experiment the same issue ?

@smnandre
Copy link
Member Author

Yep, i'll fix it on a distinct PR (i really try to not change website and packages in the same PR)

@smnandre smnandre requested a review from WebMamba June 22, 2024 04:44
smnandre added a commit to smnandre/ux that referenced this pull request Jun 22, 2024
@smnandre
[Site] Fix Turbo demos
a43b5bc 
To be merge once symfony#1929 is merged
@smnandre smnandre mentioned this pull request Jun 22, 2024
Merged
@kbond
Copy link
Member

kbond commented Jun 26, 2024

Thanks Simon.

@kbond kbond merged commit fb975f8 into symfony:2.x Jun 26, 2024
1 check passed
kbond added a commit that referenced this pull request Jun 26, 2024
@kbond
bug #1933 [Site] Fix Turbo demos (smnandre)
99eb59a 
This PR was merged into the 2.x branch.

Discussion
----------

[Site] Fix Turbo demos

To be merge once #1929 is merged

cc `@WebMamba`

Commits
-------

a43b5bc [Site] Fix Turbo demos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond Awaiting requested review from kbond

@WebMamba WebMamba Awaiting requested review from WebMamba

Assignees
No one assigned
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed Turbo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @kbond @WebMamba @carsonbot