Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.x tap tests optional ssl and compression via env variables #4356

Open
wants to merge 28 commits into
base: v2.x
Choose a base branch
from
Open

V2.x tap tests optional ssl and compression via env variables #4356

wants to merge 28 commits into from

Conversation

mirostauder
Copy link
Collaborator

@mirostauder mirostauder commented Sep 29, 2023 •
edited
Loading

modify capable TAP tests to run in a matrix
usessl: [ 'none', 'client', 'server', 'both' ]
to exercise all kinds of connections

add matrix dimension compression
compress: [ 'none', 'client', 'server', 'both' ]

@mirostauder mirostauder force-pushed the v2.x-tap_tests_opt_ssl branch 6 times, most recently from 39e0023 to 1f9db9f Compare October 2, 2023 21:40
@mirostauder
Copy link
Collaborator Author

test_mysql_connect_retries-t

# Starting a 'REGULAR' connection with user 'sbtest10' and issuing query
# Connecting: username='sbtest10' cl.use_ssl=0
ok 23 - Cipher: NULL
ok 24 - Compression: (1)
# START: Checking behavior first 'ConnectionError' in the connection
# 2023-10-11 14:13:47: Issuing query 'DO 1' to ('127.0.0.1':6033)
# Query failed with error '2002' with message 'Can't connect to MySQL server on '127.0.0.1' (111)'
# 2023-10-11 14:13:51: Issuing query 'SELECT ConnERR from stats_mysql_connection_pool WHERE hostgroup=4000 AND srv_port=51057' to ('127.0.0.1':6032)
not ok 25 - 'ConnERR' should increase by 'retries' + 2 FOR INITIAL error: (pre_failures:'18', cur_failures:'23', retries:'2')

@mirostauder mirostauder changed the title V2.x tap tests opt ssl V2.x tap tests optional ssl and compression via env variables Oct 12, 2023
@mirostauder
Copy link
Collaborator Author

retest please

@mirostauder
Copy link
Collaborator Author

retest this please

8 similar comments
@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder mirostauder marked this pull request as ready for review October 27, 2023 08:16
@mirostauder
Copy link
Collaborator Author

retest this please

2 similar comments
@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

retest this please

@mirostauder
Copy link
Collaborator Author

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mirostauder