Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devicemodel built with Linux v6.11+ #289

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jeremy90307
Copy link
Contributor

Since commit 0edb555 ("platform: Make platform_driver::remove() return void"), the original platform_driver::remove() function returned an integer value, usually an error code. This made driver developers think that errors were properly handled. However, the driver core does not stop the device removal process based on the error code, so the error code did not serve its intended purpose. Therefore, the return type was changed to void to avoid potential issues.

Make the devicemodel example run successfully on Linux v6.11+.

Since commit 0edb555 ("platform: Make platform_driver::remove() return
void"), the original `platform_driver::remove()` function returned an
integer value, usually an error code. This made driver developers think
that errors were properly handled. However, the driver core does not
stop the device removal process based on the error code, so the error
code did not serve its intended purpose. Therefore, the return type was
changed to `void` to avoid potential issues.

Make the devicemodel example run successfully on Linux v6.11+.

Testing detail:

- Tested on Raspberry Pi 5B with Raspberry Pi OS (Debian 12, Linux
  version 6.12.1-v8-16k+)

- Verified the devicemodel examples compile and load successfully
@jserv jserv merged commit 3cb12d6 into sysprog21:master Dec 12, 2024
1 check passed
@jserv
Copy link
Contributor

jserv commented Dec 12, 2024

Thank @jeremy90307 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants