Add an LED driver example using GPIO #290
Conversation
jeremy90307
force-pushed
the
master
branch
3 times, most recently
from
3a799e4 to
a64cd81
Compare
examples/led.c
Outdated
| /* The major device number. We can not rely on dynamic registration | ||
| * any more. | ||
| */ | ||
| #define MAJOR_NUM 100 |
examples/led.c
Outdated
| { | ||
| pr_info("device_open(%p)\n", file); | ||
|
|
||
| try_module_get(THIS_MODULE); |
There was a problem hiding this comment.
See if try_module_get is required or not.
There was a problem hiding this comment.
I have noticed this issue, such as issue #52, and there are still several examples using it. Let me fix it.
There was a problem hiding this comment.
If we want to remove try_module_get, we also need to stop using register_chrdev and use cdev_init and cdev_add instead.
Because with register_chrdev, we need to manually increase or decrease the module's reference count.
There was a problem hiding this comment.
The try_module_get() function should generally be avoided. The only legitimate use case is when you need to reference another module before interacting with it, such as in file operations code. While try_module_get(THIS_MODULE) appears multiple times in the kernel source code, these instances are typically bugs that need to be fixed rather than examples to follow.
There was a problem hiding this comment.
In my modified code, register_chrdev is not included. Should I use the preprocessor to make the changes?
There was a problem hiding this comment.
Because I saw that cdev already appeared in Linux v2.6.
Add an LED driver example using GPIO and add related knowledge. Test detail: - Tested on Raspberry Pi 5B with Raspberry Pi OS (Debian 12, Linux version 6.12.1-v8-16k+) - Verify that LED example compiles and loads successfully - Verify that LED turns on and off sucessfully
Add an LED driver example using GPIO and add related knowledge.
Test detail:
Tested on Raspberry Pi 5B with Raspberry Pi OS (Debian 12, Linux version 6.12.1-v8-16k+)
Verify that LED sample compiles and loads successfully
Verify that LED turns on and off sucessfully