Ensure API requests with ForceChangeset always flip creatingChangeset back off on failure
#4988
+115
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per @jobelenus there is some tricky stuff around where we keep track of the requests, and this PR would track these API requests in the ChangeSetsStore, which is probably not what we want (for places that externally track the requests). Converted to draft for the moment, and I'll think if there's a quick way to fix this before just scrapping. |
jkeiser
force-pushed
the
jkeiser/change-set-api-request
branch
from
e5cb413
to
92fedca
Compare
Besides significantly decreasing boilerplate, this ensures we always flip it back on failure (which we didn't always remember to do)
jkeiser
force-pushed
the
jkeiser/change-set-api-request
branch
from
92fedca
to
3a5cf07
Compare
jobelenus
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new
changeSetsStore.nonHeadApiRequest()function for API calls that force a new changeset to be created. It will flipcreatingChangeSeton, and then flip it back off if the API fails. There are a number of instances where we flip it on, but don't flip it back off.This should not change behavior in any instances where API requests succeed; boilerplate reduction here is entirely rote replacement (or should be--another set of eyes is welcome)