chore(sdf): always migrate si_audit database
#5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the "attempt to migrate and log errors" behavior when migrating the `si_audit` database. With this change a migration is performed, identical to migrations for the `si` and `si_layer_cache` databases. When an error is encountered, it early-returns with the error. Signed-off-by: Fletcher Nichol <[email protected]>
johnrwatson
approved these changes
Nov 29, 2024
|
We're good to revert this try-it-and-log-it behvior as we've confirmed that we're migrating successfully in production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the "attempt to migrate and log errors" behavior when migrating the
si_auditdatabase. With this change a migration is performed, identical to migrations for thesiandsi_layer_cachedatabases. When an error is encountered, it early-returns with the error.