refactor(kit): new version of InputNumber
#10031
Conversation
Tests completed successfully ✅Good job 🔥 |
| @@ -424,6 +424,11 @@ export const ROUTES: Routes = [ | |||
| loadComponent: async () => import('../components/input-number'), | |||
There was a problem hiding this comment.
Hide this route before merge
|
Visit the preview URL for this PR (updated for commit 196b579): https://taiga-previews-demo--pr10031-input-number-refactor-dem-dp9uvwis.web.app (expires Sat, 21 Dec 2024 11:28:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10031 +/- ##
==========================================
- Coverage 66.13% 65.92% -0.22%
==========================================
Files 1215 1218 +3
Lines 15720 15808 +88
Branches 2291 2239 -52
==========================================
+ Hits 10397 10421 +24
- Misses 5068 5278 +210
+ Partials 255 109 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +1.31KB +0.2% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
nsbarsukov
changed the title
InputNumberInputNumber
| @@ -22,7 +22,7 @@ test.describe('InputNumber', () => { | |||
| }); | |||
|
|
|||
| test('Infinite precision', async ({page}) => { | |||
| await tuiGoto(page, `${DemoRoute.InputNumber}/API?precision=Infinity`); | |||
| await tuiGoto(page, `${DemoRoute.InputNumberLegacy}/API?precision=Infinity`); | |||
There was a problem hiding this comment.
All changes inside this file – DemoRoute.InputNumber => DemoRoute.InputNumberLegacy + tabulation. Nothing more.
There was a problem hiding this comment.
No changes inside projects/demo/src/modules/components/input-number-legacy/**-path. Only folder renaming
| private readonly precision = computed(() => | ||
| Number.isNaN(this.numberFormat().precision) ? 2 : this.numberFormat().precision, | ||
| ); |
There was a problem hiding this comment.
Should we make BC for this logic ? 🤔
| private readonly precision = computed(() => | |
| Number.isNaN(this.numberFormat().precision) ? 2 : this.numberFormat().precision, | |
| ); | |
| private readonly precision = computed(() => | |
| Number.isNaN(this.numberFormat().precision) ? 0 : this.numberFormat().precision, | |
| ); |
Playwright test results
Details
Failed testschromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /legacy/input-number Flaky testswebkit › tests/core/hint/hint.pw.spec.ts › TuiHint › true mode hint with delay Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
nsbarsukov
force-pushed
the
input-number-refactor
branch
from
ae8dc83 to
abbf88f
Compare
nsbarsukov
changed the title
InputNumberInputNumber
nsbarsukov
requested review from
MarsiBarsi,
waterplea,
vladimirpotekhin and
mdlufy
and removed request for
a team
nsbarsukov
force-pushed
the
input-number-refactor
branch
from
abbf88f to
196b579
Compare
No description provided.