Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): fix SSR [HLJS] ReferenceError: window is not defined #3404

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

[HLJS]  ReferenceError: window is not defined
    at Object.52013 (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/52013.js:354:4)
    at __webpack_require__ (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:280663:42)
    at Function.__webpack_require__.t (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:280699:38)
    at _ZoneDelegate.invoke (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:202914:26)
    at Object.onInvoke (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:80705:33)
    at _ZoneDelegate.invoke (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:202913:52)
    at Zone.run (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:202676:43)
    at /Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:203748:36
    at _ZoneDelegate.invokeTask (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:202948:31)
    at Object.onInvokeTask (/Users/n.barsukov/WebstormProjects/taiga-ui/dist/demo/server/main.js:80692:33)

Closes #2836

What is the new behavior?

No error

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 11, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 9865141):

https://taiga-ui--pr3404-fix-ssr-hljs-error-e9zeoc80.web.app

(expires Thu, 12 Jan 2023 10:58:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Jan 11, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
332.45KB (+52B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.04KB +10%
demo/browser/runtime.(hash).js
34.71KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +52B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.21MB (+52B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit 8d1ad28 into main Jan 12, 2023
@splincode splincode deleted the fix-ssr-hljs-error branch January 12, 2023 07:10
@well-done-bot
Copy link

well-done-bot bot commented Jan 12, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

📚 - dependency highlightjs-line-numbers.js throws SSR error ReferenceError: window is not defined
3 participants