-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): highlight improvements #5841
base: main
Are you sure you want to change the base?
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Tests are running 🚀Wait for workflow run with tests to finish ☕ |
BundleMonFiles updated (3)
Unchanged files (2)
Total files change +658B +0.11% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit e289cd8): https://taiga-ui--pr5841-task-5838-tv2q2kvu.web.app (expires Thu, 06 Jun 2024 07:38:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5841 +/- ##
==========================================
+ Coverage 70.19% 71.98% +1.79%
==========================================
Files 1460 1467 +7
Lines 15934 16032 +98
Branches 2292 2276 -16
==========================================
+ Hits 11185 11541 +356
+ Misses 4369 4119 -250
+ Partials 380 372 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What about if |
This will work the same way as with regular expressions. Or do you mean that I didn't add a demo? |
Yes, you didn't add a demo |
added |
projects/kit/directives/highlight/test/highlight.directive.spec.ts
Outdated
Show resolved
Hide resolved
@waterplea @nsbarsukov let's wait for our jedi to review |
1c507d0
to
e236141
Compare
I found some problems here:
I'll think about what we can do with it, and I'll see how these problems are solved in third-party libraries. |
e03c688
to
30d1178
Compare
fixed, ready to review |
4079e42
to
00d2333
Compare
1. Adding support for multiple occurrences 2. Adding support for multiple highlights 3. Adding support for case-sensitive mode 4. Adding support for regexp
@@ -0,0 +1,5 @@ | |||
import type {TuiArrayOrValue} from '@taiga-ui/cdk/types'; | |||
|
|||
export function tuiToArray<T>(value: TuiArrayOrValue<T>): readonly T[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use coerceArray
from angular/cdk
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #5838
What is the new behaviour?