Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): enable TuiHint hover when TuiHintManual is null #9955

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(core): enable TuiHint hover when TuiHintManual is null #9955

wants to merge 4 commits into from

Conversation

MuhammedSmani
Copy link

Fixes #9935

@MuhammedSmani MuhammedSmani requested a review from a team as a code owner December 10, 2024 08:58
@MuhammedSmani MuhammedSmani requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 10, 2024 08:59
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 10, 2024 •
edited
Loading

Tests completed successfully ✅

Good job 🔥

@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 10, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 303.96KB +10%
✅ demo/browser/vendor.(hash).js
 260.19KB +10%
✅ demo/browser/runtime.(hash).js
 43.94KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +10B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.38MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode
Copy link
Member

@MuhammedSmani
image

waterplea
waterplea reviewed Dec 18, 2024
View reviewed changes
projects/core/directives/hint/hint-manual.directive.ts

public readonly type = 'hint';

constructor() {
super((subscriber) => this.stream$.subscribe(subscriber));
super((subscriber: Subscriber<boolean | null>) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong, it should remain as it was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea left review comments

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - Ability to set tuiHintManual as null
3 participants
@MuhammedSmani @splincode @waterplea