Use cohttp and eio instead of curly #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
talex5
reviewed
Sep 28, 2024
| @@ -97,19 +97,50 @@ let version = | |||
|
|
|||
| let info = Cmd.info "get-activity" ~version | |||
|
|
|||
| module Client = struct | |||
| let null_auth ?ip:_ ~host:_ _ = Ok None | |||
There was a problem hiding this comment.
We really should make a cohttp-eio-tls package with a proper authenticator.
There was a problem hiding this comment.
I can take a look at doing it this week.
There was a problem hiding this comment.
Thanks, but I'm only going to work on this PR during Hacking Days, so no pressure!
There was a problem hiding this comment.
I've updated the example to use a proper authenticator now: mirage/ocaml-cohttp#1091
It's just:
let authenticator =
match Ca_certs.authenticator () with
| Ok x -> x
| Error (`Msg m) -> Fmt.failwith "Failed to create system store X509 authenticator: %s" m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoing #12 and using
eioinstead oflwt