Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop hardcoding the path to hg on mac #338

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Stop hardcoding the path to hg on mac #338

merged 1 commit into from
Nov 30, 2023

Conversation

jcristau
Copy link
Contributor

Best to just assume it's on $PATH, since that can be set as part of the task's payload.

@jcristau jcristau requested review from a team and gbrownmozilla August 25, 2023 18:14
@jcristau
Copy link
Contributor Author

This technically breaks backwards compatibility, but in practice I suspect nothing uses this.

gabrielBusta
gabrielBusta approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@gabrielBusta gabrielBusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. If it does break something we can add hg to the path 🤷

Do you think we should do a major version bump for this?

@jcristau
Copy link
Contributor Author

Do you think we should do a major version bump for this?

Yes, I believe this warrants a major version bump.

@jcristau jcristau added the BREAKING CHANGE Backwards incompatible request that will require major version bump label Nov 27, 2023
@jcristau
Stop hardcoding the path to hg on mac
60b8b79 
Best to just assume it's on $PATH, since that can be set as part of the
task's payload.
@jcristau jcristau merged commit 14152d8 into taskcluster:main Nov 30, 2023
13 of 14 checks passed
@jcristau jcristau deleted the mac-hg branch November 30, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielBusta gabrielBusta gabrielBusta approved these changes

@gbrownmozilla gbrownmozilla gbrownmozilla approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE Backwards incompatible request that will require major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcristau @gbrownmozilla @gabrielBusta