fix(decision): cleanup temporary uv lockfiles #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing problems, as the `worker` user was trying to create the same file, but it already existed and was owned by `root`. Ensure we don't leave these lying around.
|
I guess this is why we should be using multi-stage image builds >< |
ahal
force-pushed
the
decision_tmp
branch
3 times, most recently
from
46dfa72 to
82f9abc
Compare
When using `pip` this is a no-op as `pip` already implicitly detects that the system site dir is not writeable and falls back to the user dir. For the `uv` case, this was never working and should get unblocked by this fix.
jcristau
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing problems, as the
workeruser was trying to create the same file, but it already existed and was owned byroot.Ensure we don't leave these lying around.