Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create new 'pytest-taskgraph' package to house test fixtures #613

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ahal
Copy link
Collaborator

@ahal ahal commented Dec 11, 2024

These fixtures are useful for any project that wants to test Taskgraph related transforms or scripts. By putting them in a package, we can share them to any other repos that may need them.

@ahal ahal self-assigned this Dec 11, 2024
@ahal ahal marked this pull request as draft December 11, 2024 20:21
@ahal ahal force-pushed the push-yxzwkuysqytn branch 2 times, most recently from 78810ee to 3e02136 Compare December 11, 2024 21:37
@ahal
Copy link
Collaborator Author

ahal commented Dec 11, 2024

I tried to use uv's workspaces here, but couldn't quite get it working. Using a path instead seems to work well though.

@ahal ahal force-pushed the push-yxzwkuysqytn branch from 3e02136 to 8b34827 Compare December 11, 2024 21:57
@ahal ahal marked this pull request as ready for review December 11, 2024 21:57
@ahal ahal requested review from a team and Eijebong December 11, 2024 21:57
@ahal ahal changed the title refactor: create new 'pytest-taskgraph' module to house test fixtures refactor: create new 'pytest-taskgraph' package to house test fixtures Dec 11, 2024
These fixtures are useful for any project that wants to test Taskgraph
related transforms or scripts. By putting them in a package, we can
share them to any other repos that may need them.
@ahal ahal force-pushed the push-yxzwkuysqytn branch from 8b34827 to e8b03a8 Compare December 11, 2024 22:04
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool, thank you!!

@ahal
Copy link
Collaborator Author

ahal commented Dec 12, 2024

There's a near 0% chance this is going to work perfectly on the first try, but I don't know how to test it all without creating a release. So I'll land and be prepared for a follow-up.

@ahal ahal merged commit 04b429b into taskcluster:main Dec 12, 2024
14 of 15 checks passed
@ahal ahal deleted the push-yxzwkuysqytn branch December 12, 2024 14:30
@ahal
Copy link
Collaborator Author

ahal commented Dec 12, 2024

Here is the inevitable follow-up PR I was talking about:
#614

Possibly more to come after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants