⚡️ Automated Leak Detection on CI ⚡️ #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
force-pushed
the
sjs/test-tweaks
branch
5 times, most recently
from
f325150
to
c1d64bb
Compare
samccone
force-pushed
the
sjs/test-tweaks
branch
from
c1d64bb
to
374b175
Compare
|
🍏 CI is working (angular2 fails because of no routing) |
samccone
force-pushed
the
sjs/test-tweaks
branch
from
374b175
to
e128a63
Compare
|
xref #1368 |
|
Wow, that is awesome! I'll definitely recommend using Drool to the developers where I work. |
|
I love this! Just tested this with a few apps and it's sooo good! Thanks for this, @samccone! |
passy
added a commit
that referenced
this pull request
Oct 10, 2015
⚡️ Automated Leak Detection on CI ⚡️
| return f === framework.name; | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Missing semicolon, why didn't the linting process catch this?
There was a problem hiding this comment.
Or me! Outrageous! Fixed in master with 1567e60.
There was a problem hiding this comment.
Thanks @passy! Still we should check what's wrong with the linting tooling though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR Drool is now providing us with the ability to fail CI when an implementation has memory leaks.
The perf tests are now run on every PR 👾 🍝