Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple custom protocols #151

Merged
merged 14 commits into from
Apr 11, 2021
Merged

feat: multiple custom protocols #151

merged 14 commits into from
Apr 11, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Apr 10, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@wusyong wusyong requested a review from a team as a code owner April 10, 2021 06:12
@wusyong wusyong requested review from a team April 10, 2021 06:12
@RangerMauve
Copy link

This is so awesome!

Do the custom protocols get handled as proper origins by the browser?

@wusyong
Copy link
Member Author

wusyong commented Apr 11, 2021

It is on Windows last time I checked it. But on macOS there are some subtle issues.
I believe this is also something to do with #85

@wusyong wusyong merged commit 05e0218 into dev Apr 11, 2021
@wusyong wusyong deleted the feat/customs branch April 11, 2021 06:18
@github-actions github-actions bot mentioned this pull request Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants