Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed VIES calls since Oct 28th 2021 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

berislavbabic
Copy link

@berislavbabic berislavbabic commented Nov 1, 2021

VIES calls started failing with this gem around October 28th. We traced
the issue back to the SOAPAction key being included in the request
header. Here is a quick fix to exclude the offending header.

For search purposes, the error we got was:
"Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."

Before this fix:

>> VatCheck.new('LU20260743')
=> #<VatCheck:0x00007f8b98a09828 @vat="LU20260743", @regex=true, @response={:error=>"Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."}, @vies_available=false, @vies=false>

After the fix:

>> VatCheck.new('LU20260743')
=> #<VatCheck:0x00007fc6fdabeca0 @vat="LU20260743", @regex=true, @response={:country_code=>"LU", :vat_number=>"20260743", :request_date=>Mon, 01 Nov 2021, :valid=>true, :name=>"AMAZON EU SARL", :address=>"38, AVENUE JOHN F. KENNEDY\nL-1855  LUXEMBOURG"}, @vies_available=true, @vies=true>

VIES calls started failing with this gem around October 28th. We traced
the issue back to the SOAPAction key being included in the request
header. Here is a quick fix to exclude the offending header.

For search purposes, the error we got was:
"Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."
@thomasvbeek
Copy link

Looking good from our end, would be great if someone could merge this :)

@thomasvbeek
Copy link

@fastdivision Could we merge this? Looks good from our end and would fix the error that makes the gem unusable now :)

@mvz
Copy link

mvz commented Jun 30, 2022

@fastdivision I'd really like to have this in a new release. Is there anything I can do to help move this forward?

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2022

CLA assistant check
All committers have signed the CLA.

@mvz
Copy link

mvz commented Jan 10, 2023

@berislavbabic any chance you could sign that CLA so @fastdivision or someone else at TaxJar can merge this?

@berislavbabic
Copy link
Author

@mvz sorry I missed this notification. It's now signed

@mvz
Copy link

mvz commented Jan 26, 2023

Thanks, @berislavbabic!

@berislavbabic
Copy link
Author

@fastdivision can we get this merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants