-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed VIES calls since Oct 28th 2021 #7
base: master
Are you sure you want to change the base?
Conversation
VIES calls started failing with this gem around October 28th. We traced the issue back to the SOAPAction key being included in the request header. Here is a quick fix to exclude the offending header. For search purposes, the error we got was: "Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."
Looking good from our end, would be great if someone could merge this :) |
@fastdivision Could we merge this? Looks good from our end and would fix the error that makes the gem unusable now :) |
@fastdivision I'd really like to have this in a new release. Is there anything I can do to help move this forward? |
@berislavbabic any chance you could sign that CLA so @fastdivision or someone else at TaxJar can merge this? |
@mvz sorry I missed this notification. It's now signed |
Thanks, @berislavbabic! |
@fastdivision can we get this merged please? |
VIES calls started failing with this gem around October 28th. We traced
the issue back to the SOAPAction key being included in the request
header. Here is a quick fix to exclude the offending header.
For search purposes, the error we got was:
"Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."
Before this fix:
After the fix: