Split SIPMessage into SIPRequest and SIPResponse #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADD] Created `SIPMessage.from_bytes` to create a SIPReqeust or SIPResponse
[ADD] Added SIP version regex to better determine what is a request and what is
a response if a new version of SIP is ever released
[CHANGE] Split `pyVoIP.SIP.message` into `message.message`, `message.parse`,
and `message.response_codes`
[CHANGE] Changed `pyVoIP.SIPCompatibleMethods` to `message.SIPMethod`
[ADD] Added repr for ResponseCode and SIPMethod enum [ADD] Added automatic map to populate SIPCompatibleMethods [CHANGE] Changed all existing code to use the new SIPMessage implementation [CHANGE] Changed all existing code to use the new ResponseCode enum [FIX] Fixed type annotation of `SIPMessage.from_bytes` [FIX] Fixed incorrect type annotations for SIPMessage and subclasses [FIX] Fixed some mypy errors
[FIX] Fixed flake8 and black issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206