Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Source Phase Imports rebased to Import Attributes #3492

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Normative: Source Phase Imports rebased to Import Attributes #3492

wants to merge 4 commits into from

Commits on Oct 9, 2024

  1. Add Import Attributes proposal 

    * Add Import Attributes proposal
* `npm run format`
* Updates from review
* Changes from review
* Do not re-define ImportDeclaration
* Add `assert` deprecated syntax to `export ... from`
* Remove `[no LineTerminator here]` before `with`
* Use optional symbols to reduce grammar
* Update ImportEntries and ExportEntry to use ModuleRequest Records
* Review from Michael
* Replace AttributeKey with LiteralPropertyName
* Separate ModuleRequest and LoadedModuleRequest fields
* Validate attrs when lodaing deps and not when parsing
* Merge `AssertClause` into `WithClause`, and fix missing SDOs
* Fix type annotation
* Simplify AttributesKeyword
* Reviews
* Review
* Remove support for float and bigint literal keys
* Update wording
    @nicolo-ribaudo @michaelficarra
    nicolo-ribaudo authored and michaelficarra committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2786b20 View commit details
    Browse the repository at this point in the history

  2. Review by jmdyck

    @nicolo-ribaudo @michaelficarra
    nicolo-ribaudo authored and michaelficarra committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    93f3d26 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Rebase Source Phase Imports Proposal

    @guybedford
    guybedford committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8550dd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. use must be initialized wording over should

    @guybedford
    guybedford committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a91247d View commit details
    Browse the repository at this point in the history