spec feedback from @bakkot #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Jun 29, 2023
|
Have integrated these changes into the upstream PR here: I propose we stop updating this spec file, un-publish it and instead link to the PR. Maintaining both side by side will be painful. We're now at the stage of editor reviews, and doing that on the PR will be easier than on the repo. |
|
Every completed proposal still has its rendered spec text up; I think it's pretty important for future archival purposes. |
|
Sure we can leave it up (and add a link to the readme). But the proposal text won't be updated anymore. I don't think anyone backports PR changes to the separate specs |
|
Prior to stage 4, backporting PR changes is what's typically done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the stage3 feedback from @bakkot, from tc39/ecma262#3094, where their individual comments there are resolved per the changes here.