✨ emacs-everywhere-linux-copy-function emacs-everywhere-paste-cmd #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defcustom for alternative methods of handling the clipboard on linux also added documentation of the added as well as other customizations Overlaps with issue tecosaur#28 and maybe also a fix for issue tecosaur#10 The modifications have at least a few weak spots. 1. emacs-everywhere-paste-cmd should maybe be a function 2. organization of added functions and vars 3. (eval `(... ,@Args)) is (apply ...) elsewhere 1. There's a solid argument that it's easier to use as a list: the intent is clearer and there is little ceremony. but it is weaker (can't drop into elisp) and inconsistent with emacs-everywhere-filename-function and emacs-everywhere-linux-copy-function 2. I get the sense things were well organized before I started poking around. But I'm not deep enough into to understand what should go where. 3. `emacs-everywhere-call` uses (apply #'call-process command nil t nil (remq nil args)) Just saw that. That looks cleaner than using eval. I'm here to practice lisp. Got carried away in emacs-everywhere-paste-cmd?
make-local-variable hide change from taking effect and even without it the variable change is buffer local
|
I think the idea here is decent, I'm just inclined to do it a bit differently. Expect to see this in a commit soon :) |
|
Implemented in d20adad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defcustom for alternative methods of handling the clipboard on linux
also added documentation of the added as well as other customizations
Overlaps with issue #28 and maybe also a fix for issue #10
The modifications have at least a few weak spots.
emacs-everywhere-paste-cmdshould maybe be a function instead of a list passed ontocall-process(eval(... ,@Args))when(apply ...)` is used elsewhereThere's a solid argument that it's easier to use as a list:
the intent is clearer and there is little ceremony.
but it is weaker (can't drop into elisp) and inconsistent with
emacs-everywhere-filename-functionandemacs-everywhere-linux-copy-functionI get the sense things were well organized before I started poking around.
But I'm not deep enough into to understand what should go where.
emacs-everywhere-calluses(apply #'call-process command nil t nil (remq nil args))
Just saw that. That looks cleaner than using eval. I'm here to
practice lisp. Got carried away in emacs-everywhere-paste-cmd?