Pass {USER, COREOS}_DATA separately in testcloud
#3266
Conversation
frantisekz
force-pushed
the
tc_race
branch
4 times, most recently
from
768a3ca
to
732767f
Compare
frantisekz
requested review from
psss,
lukaszachy,
happz,
thrix,
janhavlin and
martinhoyer
as code owners
frantisekz
force-pushed
the
tc_race
branch
3 times, most recently
from
aa3927b
to
98b1b23
Compare
|
/packit test |
psss
changed the title
{USER, COREOS}_DATA separately in testcloud
|
/packit test |
frantisekz
force-pushed
the
tc_race
branch
3 times, most recently
from
520b077
to
1636374
Compare
|
/packit test |
2 similar comments
|
/packit test |
|
/packit test |
|
So, the CoreOS tests failed previously, the upcoming run has https://pagure.io/testcloud/pull-request/204 included which should resolve that too. tldr. previously, we could use sock.connect_ex(("127.0.0.1", self.get_instance_port())) in testcloud CoreOS/user sessions to verify that ssh port is open, but something had changed in how this works in libvirt/qemu, and the call now instantly returns OK. |
|
@psss Reading through the results, if I am not missing anything, the issues are mainly:
which wouldn't seem caused by testcloud/this PR, and fedora-coreos failures, which I have problems reproducing locally. All in all, this seems to resolve the mysterious failures at least for normal Fedora Cloud :/ |
|
Bumped the require again in 8f4d1db to get the regression fix. |
Adjust the test for now to exercise the custom command path only. Reboot timeout in testcloud's `instance.reboot()` will be handled separately.
|
@happz, and it's green! \o/ |
Together with now staged testcloud-0.11.0, should resolve #3235 once and for all.
Required testcloud is built at: https://copr.fedorainfracloud.org/coprs/frantisekz/testcloud-temp/
The {USER, COREOS}_DATA variables were affected by threads overwriting them directly in testcloud's config object as observed in #3244 (comment) and following comments. Testcloud-side change can be seen here: https://pagure.io/testcloud/c/ee1202bcf57cd475f4586f3693e2127f9a12e92e?branch=master .
Only these two variables can differ between various instances in tmt's use of testcloud, the others are kept separately since the domain api switchover last year: #2078 .
Co-authored by @jskladan
@happz @psss
Pull Request Checklist