Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance help and option handling #191

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EmilyGraceSeville7cf
Copy link

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Sep 29, 2024

Changes

  • Use double quotes for show_usage function: termux-battery-status.in
  • Colorize show_usage text: termux-battery-status.in
  • Provide valid options when unknown is passed: termux-battery-status.in
  • Specify script type for ShellCheck to get rid of its complaints: all scripts

Questions

  • I wonder if it's desirable to color help messages or not.
  • Maybe it's a good idea to use gum instead of raw escape sequences for colors, isn't it? But in this case it's required (from my understanding) to preinstall gum too.

…us.in

- use double quotes for the help message
- suggest possible options when unknown is encountered
@EmilyGraceSeville7cf EmilyGraceSeville7cf changed the title Enhance help and option handling for: scripts/termux-battery-status Enhance help and option handling for: termux-battery-status Sep 29, 2024
@EmilyGraceSeville7cf EmilyGraceSeville7cf changed the title Enhance help and option handling for: termux-battery-status Enhance help and option handling Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant