Add CronAPI #657
Add CronAPI #657
Conversation
This implements a cron-like API which uses AlarmManager and WorkManager WorkManager is used to keep phone awake during task execution, and to be able to handle constraints - including stopping the task if constraint is no longer met
|
Thanks for implementing this. Looks good and clean overall, but its too big to review or merge at this time by me, lot of things would need to be looked at in regards to android alarms and your cron design, not going to be possible before the next app updates. |
|
I understand, take your time. |
| } | ||
|
|
||
| return String.format(Locale.getDefault(), | ||
| "%s-%d-%s", executableUri.getLastPathSegment(), jobId, String.copyValueOf(randomId)); |
There was a problem hiding this comment.
Use FileUtils.getFileBasename((UriUtils.getUriFilePathWithFragment(executableUri)) possibly with null check, read the java docs for why. However, I have locally added the com.termux.execute.executable extra for the path in TermuxService to get away from this uri mess.
There was a problem hiding this comment.
Did you actually encountered paths with # ? I know it's allowed, but it feels very wrong ;)
Anyway I applied your suggestion. Thanks.
Edit: To be honest: I should have written "I just tried it and its allowed (at least on ext4)" instead of "know" :D
There was a problem hiding this comment.
Yeah, some user reported it somewhere for termux-open, it got fixed with termux/termux-app@3e518a6
Linux allows all characters/bytes other than null byte, # isn't that unlikely, it's an ascii character after all.
This implements a cron-like API which uses AlarmManager and WorkManager
WorkManager is used to keep phone awake during task execution, and to be able to handle constraints - including stopping the task if constraint is no longer met.
Until now this has been only tested in the emulator, testing on my actual phone is next on my list. So consider this PR a "draft" but I wanted to get this out to get some "earlier" feedback about the whole concept.
Part of this relies on termux/termux-app#3821
PR for api-packages script: termux/termux-api-package#182