Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore tags_all for aws_appautoscaling_target #431

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

busla
Copy link
Contributor

@busla busla commented Feb 14, 2024

Description

see #430

Motivation and Context

Fixes perpetual drift in aws_appautoscaling_target on clusters created before 2023-03-30, see docs

Breaking Changes

None

How Has This Been Tested?

  • Tested locally on a cluster created before and after the breaking change in the AWS provider.

@busla busla changed the title fix: set ignore_changes on tags_all for aws_appautoscaling_target to support clusters provisioned before 2023 fix: Add ignore_changes on tags_all for aws_appautoscaling_target to support clusters provisioned before 2023 Feb 14, 2024
@bryantbiggs bryantbiggs changed the title fix: Add ignore_changes on tags_all for aws_appautoscaling_target to support clusters provisioned before 2023 fix: Ignore tags_all for aws_appautoscaling_target Feb 15, 2024
@bryantbiggs bryantbiggs merged commit fa8caad into terraform-aws-modules:master Feb 15, 2024
antonbabenko pushed a commit that referenced this pull request Feb 15, 2024
### [9.0.2](v9.0.1...v9.0.2) (2024-02-15)

### Bug Fixes

* Ignore `tags_all` for `aws_appautoscaling_target` ([#431](#431)) ([fa8caad](fa8caad))
@antonbabenko
Copy link
Member

This PR is included in version 9.0.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_appautoscaling_target causing perpetual drift
3 participants