Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit LayerTreeNode and MapContainer from React.PureComponent #986

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Inherit LayerTreeNode and MapContainer from React.PureComponent #986

merged 1 commit into from
Jan 16, 2019

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Jan 14, 2019 •
edited
Loading

BREAKING CHANGE | REFACTORING

This PR introduces PureComponents for LayerTreeNode and MapContainer component of react-geo so that implicitly a shouldComponentUpdate function is generated.

Description:

See also #650

@ahennr ahennr changed the title WIP: use PureComponents Inherit LayerTreeNode and MapContainer from React.PureComponent Jan 14, 2019
dnlkoch
dnlkoch approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please merge!

@ahennr ahennr merged commit e186f13 into terrestris:master Jan 16, 2019
@ahennr ahennr deleted the pure-components branch January 16, 2019 12:33
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlkoch dnlkoch dnlkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahennr @dnlkoch