Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy config folder #34

Closed
wants to merge 9 commits into from
Closed

Conversation

gaelcolas
Copy link

@gaelcolas gaelcolas commented Oct 20, 2017

This PR is backward compatible but adds a few features.
Now you can also:

  • apply MOF(s) directly (fix Suggestion: Allow raw mof input #27 )
  • copy the whole content of the configuration_script_folder,
    allowing more complex configs
  • Copy and installs modules from module_path to the node in Resource Repo
  • store your .kitchen.yml file in the root folder of a Module where
    the structure follows this:
MODULENAME
│   .kitchen.yml
│
├───ModuleName
│   │   ModuleName.psd1
│   │
│   └───DscResources
└───Modules
    └───xNetworking

Note: The kitchen root folder must have the same name as the Module folder (here ModuleName)

@smurawski
Copy link
Contributor

Thanks for the PR @gaelcolas

I'm all in on the first three changes and if you broke those out , I'd merge them right away.

The last change on the folder structure I'm not sold on. I appreciate that it isn't a breaking change, but I do have concerns about the structure.

I don't really understand the need for that additional level in the folder structure. Either the module style or repo style should encompass the needed behaviors. It feels like an edge case that is just going to add complexity to maintain.

@damacus damacus closed this Aug 21, 2023
@damacus
Copy link
Contributor

damacus commented Aug 21, 2023

Hey, Thanks for opening the PR.

If you could make the set of changes smaller, we're more likely to add them 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Allow raw mof input
3 participants