Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force supervisor to run #29

Merged
merged 3 commits into from
Sep 28, 2018
Merged

force supervisor to run #29

merged 3 commits into from
Sep 28, 2018

Conversation

skylerto
Copy link
Contributor

@skylerto skylerto commented Aug 20, 2018

Would love feedback on this, I realize the solution isn't very elegant but it solves the problem.

resolves #28

Signed-off-by: skylerto [email protected]

Signed-off-by: skylerto <[email protected]>
@gscho
Copy link
Contributor

gscho commented Aug 20, 2018

@skylerto If this is a habitat issue, should we just wait for this to be resolved instead of implementing a work around?

@skylerto
Copy link
Contributor Author

skylerto commented Aug 20, 2018

@gscho I've confirmed it isn't a habitat issue. I've ran the same code with all different versions of the supervisor (0.57.0, 0.58.0, 0.59.0, 0.61.0).

PR #30 is what I used to install different versions of habitat.

@skylerto
Copy link
Contributor Author

skylerto commented Aug 24, 2018

@jkerry can you review this please?

@gscho
Copy link
Contributor

gscho commented Sep 28, 2018

@jkerry thoughts on this PR? I'm not able to use the current kitchen-habitat release without these changes.

@jkerry
Copy link

jkerry commented Sep 28, 2018

Sorry for the delay in these guys. I don't see anything alarming here but it makes me keenly aware that we don't have any solid integration testing in place. I'm going to merge and release and keep an eye out for issues.

@gscho
Copy link
Contributor

gscho commented Sep 28, 2018

@jkerry
Created an issue for this. Thanks for merging!
#31

@jkerry jkerry merged commit 54772b6 into test-kitchen:master Sep 28, 2018
@jkerry
Copy link

jkerry commented Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with starting supervisor under nohup
3 participants