Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer norm work in progress #80

Merged
merged 6 commits into from
Feb 3, 2024
Merged

layer norm work in progress #80

merged 6 commits into from
Feb 3, 2024

Conversation

tfjgeorge
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5c61d0f) 95.47% compared to head (1d61aed) 95.23%.

Files Patch % Lines
nngeometry/layercollection.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   95.47%   95.23%   -0.24%     
==========================================
  Files          31       31              
  Lines        3579     3655      +76     
==========================================
+ Hits         3417     3481      +64     
- Misses        162      174      +12     
Flag Coverage Δ
unittests 95.23% <95.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfjgeorge
Copy link
Owner Author

this should add LayerNorm as discussed in #79

Tests are implemented for tiny fully connected and conv architectures, but for some reasons implementing LayerNorm broke the unit tests for custom layers (Cosine and WeightNorm). I will continue investigating

@tfjgeorge tfjgeorge merged commit 0b97e1a into master Feb 3, 2024
1 of 3 checks passed
@tfjgeorge tfjgeorge deleted the layernorm branch February 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant