Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: release/t24.hydra #2319

Draft
wants to merge 151 commits into
base: master
Choose a base branch
from
Draft

Test: release/t24.hydra #2319

wants to merge 151 commits into from

Conversation

Camwyn
Copy link
Member

@Camwyn Camwyn commented Dec 10, 2024

🎫 Ticket

[TICKET_ID]

🗒️ Description

🎥 Artifacts

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

JPry and others added 30 commits October 18, 2024 10:40
…P_8.3

Replace get_class() with __CLASS__
Update bucket branch from latest release
…he prefix interface: TEC\Common\Psr\Container\ContainerInterface
…s_frontend

Make event creator suppor trait more dynamic
dpanta94 and others added 25 commits December 11, 2024 19:06
…on-of-plugins

Fix/uplink activation of plugins
…without-etp-on-integrations-tab

Prevent fatal on integration page of ET when ECP without ETP
…mposer-script

Remove clean composer script
Some defensive coding brought to light the fact that we were using a function that returned a string and treating the result as an object.
$tab_object = $this->get_tab( $current_tab );
$form_classes = [
"tec-settings-form__{$current_tab}-tab--active" => true,
'tec-settings-form__subnav-active' => ( $tab_object && $tab_object->has_parent() ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'tec-settings-form__subnav-active'" and double arrow, but found 14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Status: on hold–do not proceed with other status items.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants