-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: release/t24.hydra #2319
Draft
Camwyn
wants to merge
151
commits into
master
Choose a base branch
from
release/T24.hydra
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test: release/t24.hydra #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P_8.3 Replace get_class() with __CLASS__
Update bucket branch from latest release
…he prefix interface: TEC\Common\Psr\Container\ContainerInterface
…s_frontend Make event creator suppor trait more dynamic
This is an automated PR created by dpanta94. Generated by: https://github.com/the-events-calendar/tribe-common/actions/runs/12016187034
…on-of-plugins Fix/uplink activation of plugins
…without-etp-on-integrations-tab Prevent fatal on integration page of ET when ECP without ETP
…ions Fix/uplink translations
…mposer-script Remove clean composer script
Some defensive coding brought to light the fact that we were using a function that returned a string and treating the result as an object.
Stop trying to use strings as objects.
tec-bot
reviewed
Dec 12, 2024
$tab_object = $this->get_tab( $current_tab ); | ||
$form_classes = [ | ||
"tec-settings-form__{$current_tab}-tab--active" => true, | ||
'tec-settings-form__subnav-active' => ( $tab_object && $tab_object->has_parent() ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog 🐶WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'tec-settings-form__subnav-active'" and double arrow, but found 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
[TICKET_ID]
🗒️ Description
🎥 Artifacts
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.