Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Archived Prices #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Archived Prices #350

wants to merge 1 commit into from

Conversation

Razzmatazzz
Copy link
Member

@Razzmatazzz Razzmatazzz commented Dec 15, 2024

Enables the itemArchivedPrices query

  • Must provide the id argument to specify which item's archived prices are being queried
  • Archived prices contain summary price data for the queried item, grouped by day
  • The most recent archived prices are 30 days in the past. In other words, on December 15, 2024, the most recent archived prices would be from November 15, 2024.
  • Each item's archived prices include the minimum price scanned (priceMin), the average price scanned (price), the minimum offer count (offerCountMin), and the average offer count (offerCount).
  • Offer count data is not available until the data beginning on November 20, 2024.

Modifies the itemHistoricalPrices query

  • As before, historical prices reflect a summary of price data for the queried item, grouped by individual scans
  • The maximum timespan for historical prices is now 30 days, meaning historical prices include data back until the point that archived data begins.
  • When the days argument is not provided, it defaults to the previous maximum of 7 to preserve existing behavior
  • The offerCount field has been added to indicate the number of offers available at the time of each scan

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner December 15, 2024 15:14
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Need help? Type .help as a comment or visit the usage guide for more details

Please note, if you have a more complex change, it is advised to claim a deployment lock with .lock <environment> --reason <reason> to prevent other deployments from happening while you are working on your change.

Once your PR has been merged, you can remove the lock with .unlock <environment>.

@Razzmatazzz
Copy link
Member Author

.deploy to development

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: enable-archived-prices

Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy;

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch enable-archived-prices to development

Environment URL: dev-api.tarkov.dev/graphql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant