Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR Template Update] Updating template per identified dev process improvements #300

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

kelseykropp
Copy link
Contributor

@kelseykropp kelseykropp commented Jan 12, 2024

Closes #299

🛠️ Changes Being Made

  • Formatting updates & data reorganization
  • Added note to document if dev branch should or should not be deleted after merging to main
  • New sections and sub-sections added to further detail components of dev work (Data Processing, Testing Dataset, Theiagen Version Release Testing, Reviewer Checklist, and Associated Documentation)
  • Modified content of sections (Impacted Workflows/Tasks & Changes Being Made, Workflow/Task Step Changes, Testing, and Final Developer Checklist)

Impacted Workflows/Tasks

Affects Github documenatation of Theiagen PHB PRs

🧠 Context and Rationale

The current PR template is being updated to incorporate process improvements identified during review of the current state of Theiagen's development process.

📋 Workflow/Task Steps

NA

Inputs

NA

Outputs

NA

Impacted Outputs

NA

🧪 Testing

Locally

NA

Terra

NA

Scenarios for Reviewer to Test

NA

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • [NA] The workflow/task has been tested locally and on Terra
  • [NA] The CI/CD has been adjusted and tests are passing
  • [NA] Everything follows the style guide

@kelseykropp kelseykropp added documentation This issue asks for documentation changes done This issue has been addressed labels Jan 12, 2024
@kelseykropp kelseykropp self-assigned this Jan 12, 2024
Copy link
Member

@sage-wright sage-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be great! Thank you, Kelsey!

@sage-wright sage-wright merged commit 21f7a58 into main Jan 12, 2024
3 checks passed
@sage-wright sage-wright deleted the eld-PR_template-dev branch January 12, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue asks for documentation changes done This issue has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PR Template Update] Update template per identified dev process improvements
3 participants