-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TheiaProk] Update default versions for TB-Profiler and tbp-parser #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes and doc changes look good. Will test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good to me here. read1_lane2 triggers the cascade for reads to concat which will be handled by the concatenate_lanes_workflow. Select first added for down stream side effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follows suit and style of addition of concat_lanes_workflow in wf_theiaprok_illumina_pe but with single end reads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tbp parser specific additions.
Confirming the following tests: TheiaProk_illumina_PE on ca_tb_combined Everything ran and outputs look good. Good work. Happy to merge. |
This PR closes #427
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
This PR implements several changes that were requested by users, and sets the default variant caller in TBProfiler to GATK. These changes lived on various different development branches that are very out of sync with the latest updates. This branch collects those changes.
Other changes include:
⚡ Impacted Workflows/Tasks
This PR may lead to different results in pre-existing outputs: Yes
This PR uses an element that could cause duplicate runs to have different results: No
🛠️ Changes
⚙️ Algorithm
TBProfiler -> v6.4.1
tbp-parser -> v2.1.1
➡️ Inputs
Boolean tbprofiler_additional_parameters
->Boolean call_tbp_parser
All tbp-parser optional inputs are now available for modification.
⬅️ Outputs
Int? tbprofiler_median_coverage
->Float? tbprofiler_median_depth
🧪 Testing
TheiaProk_Illumina_PE here
Suggested Scenarios for Reviewer to Test
🔬 Final Developer Checklist
🎯 Reviewer Checklist