Added aliases for Cascade::fileConfig plus a bunch of minor fixes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cheeZery Can you split this into two PRs- one with just the phpdoc fixes, and the other with the aliases? Tag me on them after. Thanks! |
This was referenced Aug 18, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now I finally came through to add that missing array param for the fileConfig method myself, as we discussed in issue #70.
While I was at it I also added two aliases for Cascade::fileConfig. I know, it's not perfect, but maybe it will do. Feel free to suggest any changes and I will implement them! :-)
I also fixed a lot of minor bugs, mainly in the phpdocs, maybe I've overdone a bit.. But most of the work did PhpStorm by itself to be completely honest.
This is also my first PR on Github so I hope I didn't made any bigger mistakes.