-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WPA/BPA display for final rounds #179
Conversation
Hey, thanks for the PR! A few high level notes:
|
Thanks, this looks awesome! One small nit - it looks like WPA / BPA are off-centre in your second-last screenshot - could we investigate the reason for this? |
@dunkOnIT fixed ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! A couple comments with respect to code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks :)
Closes #174
Now final round looks like this:
Projector view:
I'm not sure how sorting should be resolved, I think it's not bad like this, but I'm open to suggestions on how it could be done better.