Default competition_factory to registration_version = :v3 #10237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like it's all front end tests that are failing? |
|
Yep, all the frontend tests + a mailer render, which surprises me a little. My suggestion here is to rewrite the tests for v3 once we get capybara working locally, which it sounds like Gregor is close to doing? |
|
the mailer probably fails because the edit link points to the new v2 edit page |
|
The mailer failure is actually a bug (from the initial introduction of V3). Hotfix per b44fcb5 already pushed, if you rebase this PR then you should be good |
|
That was not a bug, V3 uses the same new edit registration url as V2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.